Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake updates #602

Open
wants to merge 87 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
6359119
add assertions in a bug hunt
sjunges May 24, 2024
5223187
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Jun 1, 2024
976bd76
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Jun 4, 2024
bdbc3cb
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Aug 20, 2024
52cfeea
removed untargeted include directories in favour of targeted include …
sjunges Aug 20, 2024
a221bd6
fix version exporting
sjunges Aug 20, 2024
0849dcb
Merge branch 'targetincludes' into stormpyprep
sjunges Aug 20, 2024
c7080da
stormversion prolbem
sjunges Aug 20, 2024
34b0323
cmake_dir to project_dir
sjunges Aug 20, 2024
87e6585
carl via fetchcontent
sjunges Aug 26, 2024
4e9cc97
update
sjunges Aug 28, 2024
120be47
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Aug 28, 2024
db17d6f
Merge branch 'master' into stormpyprep
sjunges Aug 28, 2024
59dd288
upate
sjunges Aug 28, 2024
4bccfc9
updates
sjunges Aug 28, 2024
dbff1a8
updates
sjunges Sep 3, 2024
0508d75
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Sep 4, 2024
cdc5c9f
Merge branch 'master' into stormpyprep
sjunges Sep 4, 2024
9531c6e
updates
sjunges Sep 4, 2024
927f22d
update
sjunges Sep 4, 2024
fbec5e3
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Sep 25, 2024
3f77cdc
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Nov 9, 2024
d76f1df
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Jan 13, 2025
891651f
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Jan 14, 2025
9782fb6
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Jan 14, 2025
2ccf76f
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Feb 3, 2025
029c09f
Merge branch 'master' into stormpyprep
sjunges Feb 4, 2025
2063d88
update some wip stuff
sjunges Feb 4, 2025
2588658
outdated skip
sjunges Feb 4, 2025
56c209d
updates to cmake building
sjunges Feb 11, 2025
77f69ce
Merge branch 'master' of https://github.com/moves-rwth/storm into sto…
sjunges Feb 11, 2025
60ec049
setting the version in some libs
sjunges Feb 12, 2025
692a95c
various updates, including some suggestions by MV
sjunges Feb 18, 2025
eb8ba83
target sources
sjunges Feb 19, 2025
250facd
buildtest stuff from MV and no more ubuntu 22.04
sjunges Feb 19, 2025
a73d3c9
typo
sjunges Feb 19, 2025
90777e7
towards an installable storm version
sjunges Feb 26, 2025
ef3a458
missing files and no old flag
sjunges Feb 26, 2025
9c3dbd6
fix commit hash for carl (for now)
sjunges Feb 26, 2025
608098e
update
sjunges Feb 26, 2025
d6b1bba
latest carl version
sjunges Feb 26, 2025
b140350
fix dependency
sjunges Feb 26, 2025
6fd5561
sylvan PIC
sjunges Feb 26, 2025
e5ff962
bugfix?
sjunges Feb 26, 2025
d17c478
pch support on linux
sjunges Feb 27, 2025
a67fad6
use carl config again
sjunges Feb 27, 2025
89ee454
add make install
sjunges Feb 27, 2025
c101a75
warning disable doesnt work
sjunges Feb 27, 2025
9bb1e97
better info
sjunges Feb 27, 2025
c88d838
no sylvan assert
sjunges Feb 27, 2025
bb68a25
Merge branch 'master' of https://github.com/moves-rwth/storm
sjunges Feb 27, 2025
f5d972b
Merge branch 'master' into stormpyprep
sjunges Feb 27, 2025
f58fe30
exit code 0 on --version
sjunges Feb 27, 2025
ae7c57a
warnings and compile flags
sjunges Mar 2, 2025
9c9acb4
updates based on CI and z3 support for older versions
sjunges Mar 2, 2025
b69e600
format and co
sjunges Mar 2, 2025
f0c68dd
find z3
sjunges Mar 2, 2025
2172aaa
ci update
sjunges Mar 3, 2025
a30d9d1
updates
sjunges Mar 3, 2025
e65ee20
ci updates (thanks MV)
sjunges Mar 3, 2025
03377ee
no shipped glpk
sjunges Mar 3, 2025
fe4a6d6
ci
sjunges Mar 3, 2025
51368b8
fix
sjunges Mar 3, 2025
f46d0c8
test?
sjunges Mar 3, 2025
806bd1e
update ci
sjunges Mar 4, 2025
2a7dbd9
updates
sjunges Mar 4, 2025
1e69891
updates in CI
sjunges Mar 7, 2025
073d5b7
Merge branch 'master' into stormpyprep
sjunges Mar 7, 2025
0d4511a
updates in spot
sjunges Mar 7, 2025
1346040
Merge branch 'stormpyprep' of https://github.com/sjunges/storm into s…
sjunges Mar 7, 2025
598ec36
update carl
sjunges Mar 10, 2025
994d640
build starter proj using installed storm
sjunges Mar 23, 2025
aa040f4
update
sjunges Mar 23, 2025
8d3ddd5
merge
sjunges Mar 23, 2025
9ab2f1f
update
sjunges Mar 23, 2025
ade2c8f
log output on failure
sjunges Mar 23, 2025
897c24f
toplevel
sjunges Mar 23, 2025
6045c6d
updates
sjunges Mar 24, 2025
a1d8b48
various fixes
sjunges Mar 24, 2025
d85bad5
updates
sjunges Mar 25, 2025
42065e8
updates
sjunges Mar 25, 2025
73f5950
Merge branch 'master' into stormpyprep
sjunges Mar 25, 2025
2e9865e
update
sjunges Mar 25, 2025
12dd139
Merge branch 'stormpyprep' of https://github.com/sjunges/storm into s…
sjunges Mar 25, 2025
8bb20dc
update
sjunges Mar 26, 2025
bdafdcc
fix mathsat
sjunges Mar 26, 2025
ff742e0
fix
sjunges Mar 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/Dockerfile.archlinux
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ ARG no_threads=1

# Specify Storm configuration (ON/OFF)
ARG gurobi_support="ON"
ARG mathsat_support="ON"
ARG soplex_support="ON"
ARG spot_support="ON"
ARG developer="OFF"
Expand Down Expand Up @@ -51,6 +52,7 @@ WORKDIR /opt/storm/build
RUN cmake .. -DCMAKE_BUILD_TYPE=$build_type \
-DSTORM_PORTABLE=ON \
-DSTORM_USE_GUROBI=$gurobi_support \
-DSTORM_USE_MATHSAT=$mathsat_support \
-DSTORM_USE_SOPLEX=$soplex_support \
-DSTORM_USE_SPOT_SYSTEM=$spot_support \
-DSTORM_DEVELOPER=$developer \
Expand All @@ -68,5 +70,4 @@ RUN make storm -j $no_threads
# (This can be skipped or adapted depending on custom needs)
RUN make binaries -j $no_threads

# Set path
ENV PATH="/opt/storm/build/bin:$PATH"
WORKDIR /opt/storm
1 change: 1 addition & 0 deletions .github/workflows/Dockerfile.doxygen
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ WORKDIR /opt/storm/build
RUN cmake .. -DCMAKE_BUILD_TYPE=Release \
-DSTORM_PORTABLE=ON \
-DSTORM_USE_GUROBI=ON \
-DSTORM_USE_MATHSAT=ON \
-DSTORM_USE_SOPLEX=ON \
-DSTORM_USE_SPOT_SYSTEM=ON

Expand Down
183 changes: 142 additions & 41 deletions .github/workflows/buildtest.yml

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/workflows/release_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
--build-arg developer="${{ matrix.buildType.Developer }}" \
--build-arg cmake_args="${{ matrix.buildType.cmakeArgs }}" \
--build-arg no_threads=${NR_JOBS}
# Omitting arguments gurobi_support, soplex_support, spot_support, cln_exact, cln_ratfunc, all_sanitizers
# Omitting arguments gurobi_support, soplex_support, mathsat_support, spot_support, cln_exact, cln_ratfunc, all_sanitizers
- name: Login to Docker Hub
# Only login if using original repo
if: github.repository_owner == 'moves-rwth'
Expand Down
229 changes: 101 additions & 128 deletions CMakeLists.txt

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ ARG spot_support="ON"
ARG developer="OFF"
ARG cln_exact="OFF"
ARG cln_ratfunc="ON"
ARG mathsat_support="ON"
ARG all_sanitizers="OFF"

# Specify additional CMake arguments for Storm
Expand All @@ -48,6 +49,7 @@ WORKDIR /opt/storm/build
RUN cmake .. -DCMAKE_BUILD_TYPE=$build_type \
-DSTORM_PORTABLE=ON \
-DSTORM_USE_GUROBI=$gurobi_support \
-DSTORM_USE_MATHSAT=$mathsat_support \
-DSTORM_USE_SOPLEX=$soplex_support \
-DSTORM_USE_SPOT_SYSTEM=$spot_support \
-DSTORM_DEVELOPER=$developer \
Expand All @@ -65,5 +67,4 @@ RUN make storm -j $no_threads
# (This can be skipped or adapted depending on custom needs)
RUN make binaries -j $no_threads

# Set path
ENV PATH="/opt/storm/build/bin:$PATH"
WORKDIR /opt/storm
2 changes: 1 addition & 1 deletion StormCPackConfig.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ include(InstallRequiredSystemLibraries)

### general settings
set(CPACK_PACKAGE_NAME "Storm")
set(CPACK_PACKAGE_VENDOR "RWTH Aachen University")
set(CPACK_PACKAGE_VENDOR "Storm Developers")
set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "Storm - A probabilistic model checker written in C++.")
set(CPACK_PACKAGE_CONTACT "[email protected]")

Expand Down
1 change: 1 addition & 0 deletions doc/update_resources.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ In case a new patch needs to be created follow these steps:
6. Resolve issues, make changes, and commit them
7. Create a new patch file via `git format-patch <new_commit_hash> --stdout > eigen.patch`, where `<new_commit_hash>` is the tag, branch or commit from step 5
8. add the patch to resources/patches/ and change the resources/3rdparty/CmakeLists.txt file accordingly.

## GLPK

To update GLPK, download the new sources from [here](https://ftp.gnu.org/gnu/glpk/) and put them into `$STORM_DIR/resources/3rdparty/glpk-5.0`.
Expand Down
Loading
Loading