Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source builds of geometric_shapes and srdfdom (backport #3233) #3387

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 19, 2025

Description

We had added these a few months back to circumvent some breakages, but this should no longer be needed.

Q: Should we backport this to Jazzy? Because if so, srdfdom there is at 2.0.5 and not 2.0.7, so I think we may need to first release to there. But I also forget whether the srdfdom version was actually a problem in Jazzy, or it was just Rolling. I guess it's worth just testing the backport?

(self-answer): I just pushed srdfdom 2.0.7 releases to humble and jazzy on rosdistro.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3233 done by [Mergify](https://mergify.com).

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.76%. Comparing base (97ee34e) to head (f5bb665).
Report is 1 commits behind head on jazzy.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3387      +/-   ##
==========================================
- Coverage   44.40%   40.76%   -3.63%     
==========================================
  Files         701      688      -13     
  Lines       61871    57194    -4677     
  Branches     7496     7496              
==========================================
- Hits        27468    23311    -4157     
+ Misses      34236    32355    -1881     
- Partials      167     1528    +1361     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sea-bass sea-bass merged commit 74fb06e into jazzy Mar 19, 2025
10 of 11 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3233 branch March 19, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants