Enable flake8-2020 linting rules #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts with ruff format
Coverage report
This PR does not seem to contain any modification to coverable code. |
austinweisgrau
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Are the new rules fully redundant with the ruff defaults, or did we just happen to follow all of them through luck / good style? The latter seems doubtful to me. Maybe they're redundant with black, if not ruff, and got taken care of with the old black formatting configs? IDK
|
I think it's a mix of all three of those, actually. |
shaunagm
approved these changes
Mar 11, 2025
|
@bmos can you take a quick look at this and either resolve the merge conflict or tell me how I should resolve it? |
bmos
changed the title
|
Updated title since all but one commit were included in #1323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable flake8-2020 linting rules