Add ruff Implicit String Concatenation Rules #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts with ruff format
Coverage report
This PR does not seem to contain any modification to coverable code. |
bmos
changed the title
austinweisgrau
approved these changes
Mar 3, 2025
|
One weird quirk about this pull request is that it seems GitHub's counts of lines of code counts explicitly concatenated strings as a single line and implicitly concatenated strings as multiple lines. That's why this pull request shows that multiple lines of code are being added when technically it's just a single line of code being added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1324, this PR adds flake8-implicit-string-concat rules which ask contributors to use implicit multi-line string concatenation rather than explicit multi-line concatenation.
It also contains code changes to resolve all resulting errors.
No changes to code behavior.