Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff Implicit String Concatenation Rules #1323

Merged
merged 8 commits into from
Mar 11, 2025

Conversation

bmos
Copy link
Contributor

@bmos bmos commented Mar 1, 2025

Built on top of #1324, this PR adds flake8-implicit-string-concat rules which ask contributors to use implicit multi-line string concatenation rather than explicit multi-line concatenation.

It also contains code changes to resolve all resulting errors.
No changes to code behavior.

@bmos bmos closed this Mar 1, 2025
Copy link

github-actions bot commented Mar 1, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

@bmos bmos changed the title Implicit String Concatenation Rules Add ruff Implicit String Concatenation Rules Mar 2, 2025
@bmos bmos reopened this Mar 2, 2025
Copy link
Collaborator

@austinweisgrau austinweisgrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh i like this one

@bmos
Copy link
Contributor Author

bmos commented Mar 3, 2025

One weird quirk about this pull request is that it seems GitHub's counts of lines of code counts explicitly concatenated strings as a single line and implicitly concatenated strings as multiple lines. That's why this pull request shows that multiple lines of code are being added when technically it's just a single line of code being added.

@shaunagm shaunagm merged commit c727257 into move-coop:main Mar 11, 2025
135 checks passed
@bmos bmos deleted the implicit-str-concat branch March 11, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants