⚡️ lazily load serialized portfolio #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mingi3314 and the rest of your teammates on |
This was referenced Mar 31, 2024
Merged
Merge activity
|
Base automatically changed from
03-31-_add_profit_field_to_position_model_and_portfolio_class
to
main
March 31, 2024 13:18
mingi3314
force-pushed
the
03-31-_lazily_load_serialized_portfolio
branch
from
4d96e46 to
625239b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR improves the performance of portfolio value calculation.
What changed?
The PR changes how the portfolio value is calculated and fetched. Previously, the serialized portfolio was fetched on every call, which would cause unnecessary API calls and slow down the application. With this PR, the serialized portfolio is only fetched when needed, and then stored in an instance variable for later use.
How to test?
Track the time taken to fetch portfolio value before and after this change.
Check for any inconsistencies in the fetched data
Why make this change?
This change reduces the number of API calls and improve the performance of the application.