✨ Add profit field to Position model and Portfolio class #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mingi3314 and the rest of your teammates on |
This was referenced Mar 31, 2024
Merged
Merge activity
|
mingi3314
deleted the
03-31-_add_profit_field_to_position_model_and_portfolio_class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
The current pull request updates the
Positionmodel by introducing a new fieldprofitand modifies unit tests to reflect this change.What changed?
A new field
profithas been introduced in thePositionmodel found in 'pyrb/models/position.py'. Corresponding changes are also made in 'pyrb/repositories/brokerages/ebest/portfolio.py' and test files.How to test?
Run unit tests to ensure all the changes work as expected.
Why make this change?
This additional field
profitcan provide more detailed insights about the individual positions held within the portfolio.