Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert file ext to lowercase for format detection #2121

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

ryenus
Copy link
Contributor

@ryenus ryenus commented Aug 5, 2024

To ensure proper file format detection with case-insensitive file systems.

To ensure proper file format detection with case-insensitive file
systems.
@ryenus
Copy link
Contributor Author

ryenus commented Aug 5, 2024

Before

[DEBUG] 09:45:24 format.go:112 FormatStringFromFilename checking file extension 'T.JSON' for auto format detection
[DEBUG] 09:45:24 format.go:116 FormatStringFromFilename detected format 'JSON'
[DEBUG] 09:45:24 utils.go:72 initCommand Unknown file format extension 'JSON', defaulting to yaml

After

[DEBUG] 09:50:39 format.go:112 FormatStringFromFilename checking file extension 'T.JSON' for auto format detection
[DEBUG] 09:50:39 format.go:116 FormatStringFromFilename detected format 'json'
[DEBUG] 09:50:39 utils.go:97 initCommand Using input format json

pkg/yqlib/format.go Outdated Show resolved Hide resolved
@mikefarah mikefarah merged commit b9c3ff6 into mikefarah:master Aug 5, 2024
3 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 10, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [mikefarah/yq](https://github.com/mikefarah/yq) | patch | `v4.44.2` -> `v4.44.3` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>mikefarah/yq (mikefarah/yq)</summary>

### [`v4.44.3`](https://github.com/mikefarah/yq/releases/tag/v4.44.3)

[Compare Source](mikefarah/yq@v4.44.2...v4.44.3)

-   Fixed upper-case file extension detection, Thanks [@&#8203;ryenus](https://github.com/ryenus) ([#&#8203;2121](mikefarah/yq#2121))
    -   Log printing follow no-colors flag [#&#8203;2082](mikefarah/yq#2082)
    -   Skip and warn when interpolating strings and theres a unclosed bracket [#&#8203;2083](mikefarah/yq#2083)
    -   Fixed CSV content starting with # issue [#&#8203;2076](mikefarah/yq#2076)
    -   Bumped dependencies

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants