Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equality check instead of assignment when comparing private properties #1120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Equality check instead of assignment when comparing private properties #1120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cccfcb0
Equality check instead of assignment when comparing private properties
j-machuca Jul 29, 2024
dfea0f6
Change assignment to comparison
j-machuca Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/website/content/blog/fundamentals-v4/11-classes/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,8 @@ class Car {
#serialNumber in other) {
other
// ^?
return other.#serialNumber = this.#serialNumber
// Shouldn't this have a `==` or `===`? Seems like we want to return True if they're the same or False if not
return other.#serialNumber === this.#serialNumber
}
return false
}
Expand Down