Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equality check instead of assignment when comparing private properties #1120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Equality check instead of assignment when comparing private properties #1120

wants to merge 2 commits into from

Conversation

j-machuca
Copy link 

equals(other: unknown) {
    if (other && typeof other === "object" && #serialNumber in other) {
      other;
      // ^?
      return other.#serialNumber = this.#serialNumber;
    }
    return false;
  }

I believe that the intent was to return true not to assign a new value to #serialNumber

@j-machuca
Equality check instead of assignment when comparing private properties
cccfcb0 
```ts
equals(other: unknown) {
    if (other && typeof other === "object" && #serialNumber in other) {
      other;
      // ^?
      return other.#serialNumber = this.#serialNumber;
    }
    return false;
  }
```

I believe that the intent was to return true not to assign a new value to `#serialNumber`

Signed-off-by: Jorge Machuca <[email protected]>
@j-machuca
Change assignment to comparison
dfea0f6 
Signed-off-by: Jorge Machuca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j-machuca