Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glib up to gtk] update and make it work with meson #13100

Merged
merged 221 commits into from
Apr 26, 2021

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Aug 23, 2020

Some help would be nice.
Don't have the time to fix all those regressions.....
Probably involves just switching all dependent ports form the custom cmake to their native meson build.

depends:

breaks: #15034
supersedes: #12320 #9799 #16815 #16036
conflicts #16825
closes #15816 ?
closes #11797 (upgrade to 4.0)
closes #10389
closes #6683 (installs required pc files; should have been closed eariler since pc files work since a long time with meson?)
should close: #12428 #9012
maybe: #6554
partly: #5798 (missing libnice update)
closes #15877
closes #16249
closes #16457

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision labels Aug 24, 2020
@cenit cenit mentioned this pull request Aug 24, 2020
ports/glib/portfile.cmake Outdated Show resolved Hide resolved
ports/atk/portfile.cmake Outdated Show resolved Hide resolved
ports/atkmm/portfile.cmake Outdated Show resolved Hide resolved
ports/cairomm/portfile.cmake Outdated Show resolved Hide resolved
ports/cairomm/portfile.cmake Outdated Show resolved Hide resolved
ports/gdk-pixbuf/portfile.cmake Outdated Show resolved Hide resolved
ports/libxmlpp/portfile.cmake Outdated Show resolved Hide resolved
ports/pango/portfile.cmake Outdated Show resolved Hide resolved
ports/pango/portfile.cmake Outdated Show resolved Hide resolved
ports/pangomm/portfile.cmake Outdated Show resolved Hide resolved
ports/pixman/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 23, 2021
@JackBoosY
Copy link
Contributor

JackBoosY commented Apr 23, 2021

@Neumann-A I can't repro the baseline regression, I rememeber I already fixed marble, but don't know why it happened again.

Regression with openmvg:

CMake Error at D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:218 (message):
  Could NOT find LAPACK (missing: LAPACK_LIBRARIES)
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:582 (_FPHSA_FAILURE_MESSAGE)
  D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindLAPACK.cmake:524 (find_package_handle_standard_args)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
  D:/installed/x86-windows/share/suitesparse/suitesparse-config.cmake:8 (find_dependency)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
  D:/installed/x86-windows/share/ceres/CeresConfig.cmake:221 (find_dependency)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  CMakeLists.txt:284 (find_package)

@Neumann-A
Copy link
Contributor Author

@JackBoosY Seems like marble still has a baseline regression:

-- Could NOT find Qt5Positioning (missing: Qt5Positioning_DIR)
CMake Warning at C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package):
  Found package configuration file:

    D:/installed/x64-windows/share/cmake/Qt5/Qt5Config.cmake

  but it set Qt5_FOUND to FALSE so package "Qt5" is considered to be NOT
  FOUND.  Reason given by package:

  Failed to find Qt5 component "Positioning" config file at
  "D:/installed/x64-windows/share/cmake/Qt5Positioning/Qt5PositioningConfig.cmake"

@JackBoosY
Copy link
Contributor

@Neumann-A The real reason is:

CMake Error at D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:218 (message):
  Could NOT find Gettext (missing: GETTEXT_MSGMERGE_EXECUTABLE
  GETTEXT_MSGFMT_EXECUTABLE)
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:582 (_FPHSA_FAILURE_MESSAGE)
  D:/downloads/tools/cmake-3.19.2-windows/cmake-3.19.2-win32-x86/share/cmake-3.19/Modules/FindGettext.cmake:81 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  D:/installed/x64-windows/share/kf5i18n/KF5I18nMacros.cmake:5 (find_package)
  D:/installed/x64-windows/share/kf5i18n/KF5I18nConfig.cmake:33 (include)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  D:/installed/x64-windows/share/ECM/find-modules/FindKF5.cmake:53 (find_package)
  C:/a/1/s/scripts/buildsystems/vcpkg.cmake:861 (_find_package)
  MarbleMacros.cmake:124 (find_package)
  src/apps/marble-kde/CMakeLists.txt:14 (macro_optional_find_package)

I already fixed that in #17341, no idea why it happened again.

@brad-anderson
Copy link
Contributor

Why did this remove the unofficial-Cairo CMake target installation?

@Neumann-A
Copy link
Contributor Author

Why did this remove the unofficial-Cairo CMake target installation?

because it was unofficial and is not the recommended way to consume cairo. Use FindPkgConf.cmake https://cmake.org/cmake/help/latest/module/FindPkgConfig.html

IF you need a pkg-config substitute on windows. vcpkg offers pkgconf via a port

@brad-anderson
Copy link
Contributor

Why create and recommend in the post installation instructions the unofficial vcpkg targets at all if they aren't supposed to be used? Moving from nice, albeit, "unofficial" CMake targets to messy pkgconfig stuff feels like a step back.

I think it would probably have been a good idea to add post install instructions for cairo if you were going to break the builds of everyone using cairo by the apparently formally recommended method. Other ports still make use of cairo via unofficial-Cairo so those need to be updated.

Also, I don't know if you noticed but the static build is also broken now (on Windows at least).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
10 participants