-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serializing special characters in Jsonite #5124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It might be interesting to use a DynamicData
source instead of the foreach so we can replay easily but not blocking on it.
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/Json/Jsonite/Jsonite.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n/Jsonite/Jsonite.cs Co-authored-by: Youssef Victor <[email protected]>
This is addressed in comments. I did not want to emit the data, because then too many serializers need to handle them correctly to get the results. If any of them is broken (dynamic data serializer or the protocol serializer) we get no info about the test in UI, leaving us blind. // This could be converted to Data source, but this way we have more control about where in the result message the |
Tests passed, new commit is adding just comment. |
Didn't think about it but makes total sense! Thanks! |
/backport to rel/3.8 |
Started backporting to rel/3.8: https://github.com/microsoft/testfx/actions/runs/13521711902 |
Fix #5120