Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rel/3.8] Fix serializing special characters in Jsonite #5125

Open
wants to merge 3 commits into
base: rel/3.8
Choose a base branch
from

Conversation

youssef-backport-bot
Copy link

Backport of #5124 to rel/3.8

/cc @Evangelink @nohwnd

Evangelink
Evangelink previously approved these changes Feb 25, 2025
@Evangelink Evangelink enabled auto-merge (squash) February 25, 2025 12:59
@Youssef1313
Copy link
Member

@nohwnd Build is failing here. Want to take a look?

@nohwnd
Copy link
Member

nohwnd commented Feb 25, 2025

I've simplified the test, in 3.9 we get System.Text.Json available in .NET Framework thanks to updated dependency on Code Coverage, which updaged from version that used Newtonsoft.Json.

S:\p\testfx [backport/5124/to/rel/3.8 ≡]> dotnet nuget why S:\p\testfx\test\UnitTests\Microsoft.Testing.Platform.UnitTests\Microsoft.Testing.Platform.UnitTests.csproj system.text.json
Project 'Microsoft.Testing.Platform.UnitTests' has the following dependency graph(s) for 'system.text.json':

  [net6.0/win-x86]
  [net6.0]
   │
   └─ Microsoft.Testing.Extensions.CodeCoverage (v17.13.1)
      └─ Microsoft.Extensions.DependencyModel (v6.0.1)
         └─ System.Text.Json (v6.0.10)

  [net462/win-x86]
  [net462]
  [net7.0/win-x86]
  [net7.0]
  [net8.0/win-x86]
  [net8.0]
  [net9.0/win-x86]
  [net9.0]
   │
   └─ No dependency graph(s) found for this target framework.

@nohwnd
Copy link
Member

nohwnd commented Feb 25, 2025

/azp run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants