-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better types and tests for useKeyProps #2468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
commented
Dec 28, 2022
packages/utils/interactive-hooks/src/__tests__/useKeyProps.test.tsx
Outdated
Show resolved
Hide resolved
Saadnajmi
changed the title
Better types + tests for useKeyProps
Better types and tests for useKeyProps
Dec 28, 2022
rurikoaraki
reviewed
Dec 29, 2022
Saadnajmi
commented
Dec 29, 2022
amgleitman
reviewed
Dec 29, 2022
rurikoaraki
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This PR makes the following improvements to
useKeyProps
:useKeyProps.<platform>.ts
files into one. There was starting to be a lot of duplicated logic. Now that the types are separated out, I think the main file can be one combined one.All in all, this is mostly a quality of life improvement.
Verification
CI should pass
Pull request checklist
This PR has considered (when applicable):