Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More useKeyProps followup #2477

Merged
merged 3 commits into from
Jan 4, 2023
Merged

More useKeyProps followup #2477

merged 3 commits into from
Jan 4, 2023

Conversation

Saadnajmi
Copy link
Collaborator

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

This PR makes a few changes, ordered in rough importance:

  1. Don't specify keyDownEvents and keyUpEvents on Windows
  1. Fix mismatched macOS type
  • I had accidentally swapped the macOS and base type files for useKeyProps.types.ts. Simple swap back to fix.
  1. Refactor the tests to call the hook inside a component
  • This is closer to how the hook is meant to be used, so I thought that should be a good change.
  1. Move deprecated useKeyCallback to bottom of file.
  • This is just to make it more clear it's deprecated and not used for anything else.

Verification

(how the change was tested, including both manual and automated tests)

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@Saadnajmi Saadnajmi requested a review from a team as a code owner January 3, 2023 16:42
@Saadnajmi Saadnajmi merged commit 60c0e92 into microsoft:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants