Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change jest endpoint to win32 for Checkbox and Switch #2364

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

rurikoaraki
Copy link
Collaborator

@rurikoaraki rurikoaraki commented Nov 28, 2022

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Changing the jest endpoint to win32 for the aforementioned components, as they are mainly used in win32.
This consists of changing the config file to win32 and adding RN Win32 as a dev dependency to these packages.

The tests are failing due to two bugs, so this will stay a draft for now.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@rurikoaraki rurikoaraki changed the title Change jest endpoint to win32 for Callout, Checkbox, Menu, MenuButton, Separator, Switch, Tab Change jest endpoint to win32 for Checkbox and Switch Nov 29, 2022
@Saadnajmi
Copy link
Collaborator

Blocked by microsoft/react-native-windows#10942 and a future PR to address memorizing keyUp/DownEvents iirc

…tive; branch 'main' of github.com:microsoft/fluentui-react-native into test_win32
@Saadnajmi
Copy link
Collaborator

Despite the extra tests I wrote for useKeyProps, this still fails locally for me as well. I'm pretty confused what the discrepancy is, so I'm still investigating 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants