-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change jest endpoint to win32 for Checkbox and Switch #2364
Draft
rurikoaraki
wants to merge
12
commits into
microsoft:main
Choose a base branch
from
rurikoaraki:test_win32
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurikoaraki
changed the title
Change jest endpoint to win32 for Callout, Checkbox, Menu, MenuButton, Separator, Switch, Tab
Change jest endpoint to win32 for Checkbox and Switch
Nov 29, 2022
Blocked by microsoft/react-native-windows#10942 and a future PR to address memorizing |
…tive; branch 'main' of github.com:microsoft/fluentui-react-native into test_win32
10 tasks
Despite the extra tests I wrote for useKeyProps, this still fails locally for me as well. I'm pretty confused what the discrepancy is, so I'm still investigating 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Changing the jest endpoint to win32 for the aforementioned components, as they are mainly used in win32.
This consists of changing the config file to win32 and adding RN Win32 as a dev dependency to these packages.
The tests are failing due to two bugs, so this will stay a draft for now.
Pull request checklist
This PR has considered (when applicable):