Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure correct script kind and text when using cached sourceFile from scriptInfo #57641

Merged
merged 2 commits into from Mar 4, 2024
Merged

Ensure correct script kind and text when using cached sourceFile from scriptInfo #57641

merged 2 commits into from Mar 4, 2024

Commits on Mar 4, 2024

  1. Add test for script kind mistmatch because existing source file is us… 

    …ed incorrectly
    @sheetalkamat
    sheetalkamat committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    ac376fc View commit details
    Browse the repository at this point in the history

  2. When using cached sourceFile from the info, make sure the scriptKind … 

    …is same

This is needed esp with externalFiles since they may not use actual scriptInfo and text at all
Fixes #57631
    @sheetalkamat
    sheetalkamat committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a59f129 View commit details
    Browse the repository at this point in the history