Ensure correct script kind and text when using cached sourceFile from scriptInfo #57641
+487
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
force-pushed
the
scriptKindWithPlugin
branch
from
faad4b8
to
aada58d
Compare
…is same This is needed esp with externalFiles since they may not use actual scriptInfo and text at all Fixes #57631
sheetalkamat
force-pushed
the
scriptKindWithPlugin
branch
from
aada58d
to
a59f129
Compare
jakebailey
approved these changes
Mar 4, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using cached sourceFile from the info, make sure the scriptKind is same
This is needed esp with externalFiles since they may not use actual scriptInfo and text at all
Fixes #57631