Implement basic AsType tests for long vectors. #7668
+554
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
V-FEXrt
approved these changes
Jul 25, 2025
| template <typename DataTypeT, typename LongVectorOpTypeT> | ||
| bool LongVector::TestConfig<DataTypeT, LongVectorOpTypeT>::resolveOutputTypeAndVerifyOutput(MappedData &ShaderOutData) { | ||
|
|
||
| if constexpr (std::is_same_v<LongVectorOpTypeT, LongVector::UnaryOpType>) { |
There was a problem hiding this comment.
nit: same here for early exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test cases for most of the 'AsType' HLSL intrinsics. It introduces changes to facilitate testing an HLSL intrinsic with an output type that does not match the input type. This functionality required some changes to the TestConfig object as well as the addition of a 'VariantVector' alias to store the expected output.
Verified locally by running new and all existing long vector exec test cases against WARP.
Resolves #7473