-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add concurrency to Exponential Histogram #5749
base: 1.14.x
Are you sure you want to change the base?
Add concurrency to Exponential Histogram #5749
Conversation
1029615
to
d67f3e3
Compare
d67f3e3
to
6fca20c
Compare
- Rescaling is not frequent behaviour (for cumulative scale should normalize after initial few recording, for delta it could increase/decrease but would be mostly stable). Instead of opting for a full synchronization on writes (which would have less performance), the choice of ReadWriteLock is chosen.
6fca20c
to
72cb6b1
Compare
I initially thought that using a Existing Implementation
Full Synchronization (the current state of PR)
Full Synchronization with AtomicLongArray (we have been using a AtomicLongArray until now)
ReadWrite Locks (Implementation in the first commit of this PR)
I will leave the ReadWriteLock implementation in the commit history so if someone has a look at it, then can run the tests as well (or correct me if I am doing something wrong there). I add a second commit to drop those changes and add synchronization to the writes. |
Guard the entire write operation externally for exponential histogram.
TODO:
Fixes #5740