-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve microG settings (fix issue #758 and more) #765
Conversation
Separate launcher icon from main activity so it can be disabled manualy without breaking app functional. Some users at russian community reported that microg stop worhing after disabling main activity to hide microg from launcher (damn it is logical that it will break this activity functional !!) In future it can be used as part of custom setting to hide launcher icon
Fix icon being not displayed on some devices with android 6, 7 and 7,1 (SDK 23,24,25)
…microG settings from appinfo
* Move some translations to strings * Move some translations to strings * Move some translations to strings RU * Better icon style for settings integration
|
|
Can you change the class/xml name of the account settings to not be "add account"? It's a little confusing ;) Thanks. |
Also you are lacking the logic code required for the |
Yes, of course, completely missed it out. Will fix it later today.
Am 29. Mai 2019 17:19:47 MESZ schrieb Marvin W <[email protected]>:
…Also you are lacking the logic code required for the
`auth_manager_visible` preferences to be applied directly (as
implemented in the `AccountSettingsActivity`)
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#765 (comment)
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
|
Hi @mar-v-in ! What do you think about simplify string "Google Cloud Messaging" to "Cloud Messaging" or something else ? Because GCM is not exist anymore and it can confuse users |
If there's anything left you'd like to see changed, just let me know. |
How about using this Android 9 compliant settings menu icon? The current icon looks sort of wrong with Pie.
|
@oldosfan what ROM are you using? For me it looks normal on Pie (both in Launcher and System Settings), maybe post a screenshot. @mar-v-in is there anything left you'd like to see changed/improved? |
@mar-v-in any interest in the parts which can be rebased on latest code? |
|
see #1191 for replacement. |
Follow up commit to #719 and #741 includes: