Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microG Settings integration, icon/activity changes #1191

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Nanolx
Copy link
Contributor

@Nanolx Nanolx commented Sep 23, 2020

Follow up for #765

…out breaking microG functionality.

- Think of launchers that can't hide apps, so you need to disable the launcher activity in order to hide it.
- Also useful when microG is embedded inside System Settings, and you want to disable the launcher icon.
- Could in theory be used in the future for a feature "hide app icon" inside microG settings itself
…1 (SDK 23,24,25)

- correct category for System Settings embedding
@@ -485,7 +507,7 @@
android:resource="@string/gms_settings_summary" />
</activity-alias>

<!-- Separate launcher icon from main activity so it can be disabled manualy -->
<!-- microG Settings activity-alias shown in Launcher -->
<activity-alias
android:enabled="true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be interesting to try something like this:
android:enabled="@bool/is_alias_enabled"
then add <bool name="is_alias_enabled">true</bool> to bools.xml
and create ../values-v23/bools.xml with this

<?xml version="1.0" encoding="utf-8"?>
<!--
  ~ Copyright (C) 2020 microG Project Team
  ~
  ~ Licensed under the Apache License, Version 2.0 (the "License");
  ~ you may not use this file except in compliance with the License.
  ~ You may obtain a copy of the License at
  ~
  ~     http://www.apache.org/licenses/LICENSE-2.0
  ~
  ~ Unless required by applicable law or agreed to in writing, software
  ~ distributed under the License is distributed on an "AS IS" BASIS,
  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  ~ See the License for the specific language governing permissions and
  ~ limitations under the License.
  -->

<resources>
    <bool name="is_alias_enabled">false</bool>
</resources>

So launcher icon should be always disabled Android 6.0 and newer.
Settings integration is available starting from this android version.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So launcher icon should be always disabled Android 6.0 and newer. Settings integration is available starting from this android version.

Honeslty I think that can be still visible, is a shortcut, wothout go on settings>system>microg.
For the same reason I have installed an app to open update on lineageos.

@Vavun
Copy link
Contributor

Vavun commented Dec 9, 2020

Hello @Nanolx

Maybe you can find time to update this pull request?
A lot of things have changed.

@Nanolx
Copy link
Contributor Author

Nanolx commented Jan 3, 2021

I'll have a look at it next week.

@ghost
Copy link

ghost commented Mar 19, 2021

Did this slip through the cracks? This would be super nice to have 👀

@ILoveOpenSourceApplications

@Nanolx, I don't know if you're free to be able to look into this right now or not. But if possible, it'll be much appreciated. Sorry if I bothered you.

@ale5000-git
Copy link
Member

This PR is obsolete because most of its stuff is already merged separately in microG.

@ILoveOpenSourceApplications
Copy link

Ah, I see you took it into your own hands and did #2042 & #2061. I did check for any similar PRs, but didn't check thoroughly, my bad. But then, why leave this open still, given that it's obsolete now?

Edit: On a similar note, is #1489 also obsolete?

@ale5000-git
Copy link
Member

How I have said "most of its stuff is already merged separately in microG" but probably there is still a small part that isn't, but it need to adapted to the latest code of microG and I don't have time currently.

About #1489 probably yes since the icon of microG got changed in the meantine but I don't have time to check carefully the PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants