Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Manager Binary in a Modular Way #135

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Build Manager Binary in a Modular Way #135

merged 2 commits into from
Sep 10, 2024

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Sep 5, 2024 •
edited
Loading

Why we need this PR

Allow default values for building Golang manager binary using build.sh, and support for other flags.

Changes made

  • Build manager binary in a modular way

Relates to ECOPROJECT-1972

Test plan

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

slintes
slintes reviewed Sep 5, 2024
View reviewed changes
hack/build.sh Outdated Show resolved Hide resolved
@razo7 razo7 force-pushed the fips-compliance-check branch from 3ed75eb to 3ba2467 Compare September 7, 2024 09:59
@razo7 razo7 changed the title Validate FIPS compliance Build Manager Binary in a Modular Way Sep 7, 2024
@razo7 razo7 force-pushed the fips-compliance-check branch 2 times, most recently from d19b9e8 to abbba4d Compare September 7, 2024 12:30
@razo7
Build manager binary in a modular way
7d75b5e 
Allow overriding CGO_ENABLED value, debug flags as part of ldflags, and exporting GOEXPERIMENT
@razo7 razo7 force-pushed the fips-compliance-check branch from abbba4d to 7d75b5e Compare September 7, 2024 13:10
slintes
slintes reviewed Sep 9, 2024
View reviewed changes
hack/build.sh Outdated Show resolved Hide resolved
hack/build.sh Outdated Show resolved Hide resolved
@razo7
Remove comment and env var existance
db81287 
The comment is irrelevant and the check is redundant
@openshift-ci openshift-ci bot added the lgtm label Sep 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 marked this pull request as ready for review September 10, 2024 12:47
@openshift-ci openshift-ci bot requested review from clobrano and slintes September 10, 2024 12:48
@openshift-merge-bot openshift-merge-bot bot merged commit 7581e2d into medik8s:main Sep 10, 2024
27 checks passed
This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
@razo7
Copy link
Member Author

razo7 commented Nov 6, 2024

/cherry-pick release-0.17

@openshift-cherrypick-robot
Copy link

@razo7: new pull request created: #137

In response to this:

/cherry-pick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clobrano clobrano Awaiting requested review from clobrano

@slintes slintes Awaiting requested review from slintes

Assignees

@slintes slintes

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razo7 @openshift-cherrypick-robot @slintes