-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build manager binary in a modular way #145
Build manager binary in a modular way #145
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allow overriding CGO_ENABLED value, debug flags as part of ldflags, and exporting GOEXPERIMENT
1e4b696
to
805f28e
Compare
#!/bin/bash | ||
set -ex | ||
|
||
#!/bin/bash -ex | ||
DEST_DIR=$1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why it is used here. Other operators create in bin directory (we already create it in https://github.com/medik8s/machine-deletion-remediation/pull/145/files#diff-3d78da75ea6dd0aa86fac99d385c70af27002c3d2cc205934432150e2f2ccf9cR10),
Any thoughts? @clobrano
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The makefile builds the binary under bin/
directory, but the Dockerfiles have the binary built directly in the root
I don't really remember why, but it is on purpose
/test ? |
@mshitrit: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test 4.16-openshift-e2e |
/lgtm |
/retest |
1 similar comment
/retest |
/cherry-pick release-0.3 |
@razo7: new pull request created: #146 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why we need this PR
Allow default values for building Golang manager binary using build.sh, and support for other flags.
Changes made
Relates to ECOPROJECT-1972
Test plan
Similar to medik8s/node-maintenance-operator#135