Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build manager binary in a modular way #145

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Sep 18, 2024

Why we need this PR

Allow default values for building Golang manager binary using build.sh, and support for other flags.

Changes made

  • Build manager binary in a modular way

Relates to ECOPROJECT-1972

Test plan

Similar to medik8s/node-maintenance-operator#135

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Allow overriding CGO_ENABLED value, debug flags as part of ldflags, and exporting GOEXPERIMENT
@razo7 razo7 force-pushed the modular-manager-binary branch from 1e4b696 to 805f28e Compare September 18, 2024 09:47
#!/bin/bash
set -ex

#!/bin/bash -ex
DEST_DIR=$1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it is used here. Other operators create in bin directory (we already create it in https://github.com/medik8s/machine-deletion-remediation/pull/145/files#diff-3d78da75ea6dd0aa86fac99d385c70af27002c3d2cc205934432150e2f2ccf9cR10),
Any thoughts? @clobrano

Copy link
Contributor

@clobrano clobrano Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The makefile builds the binary under bin/ directory, but the Dockerfiles have the binary built directly in the root

https://github.com/clobrano/machine-deletion-remediation/blob/2632f1609758846a91614ebe88fe3696ae64fa2d/Makefile#L189-L190

https://github.com/clobrano/machine-deletion-remediation/blob/2632f1609758846a91614ebe88fe3696ae64fa2d/Dockerfile#L36-L37

I don't really remember why, but it is on purpose

@mshitrit
Copy link
Member

/test ?

Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.12-ci-bundle-machine-deletion-remediation-bundle
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.12-test
  • /test 4.13-ci-bundle-machine-deletion-remediation-bundle
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.13-test
  • /test 4.14-ci-bundle-machine-deletion-remediation-bundle
  • /test 4.14-images
  • /test 4.14-openshift-e2e
  • /test 4.14-test
  • /test 4.15-ci-bundle-machine-deletion-remediation-bundle
  • /test 4.15-images
  • /test 4.15-openshift-e2e
  • /test 4.15-test
  • /test 4.16-ci-bundle-machine-deletion-remediation-bundle
  • /test 4.16-images
  • /test 4.16-openshift-e2e
  • /test 4.16-test
  • /test 4.17-ci-bundle-machine-deletion-remediation-bundle
  • /test 4.17-images
  • /test 4.17-openshift-e2e
  • /test 4.17-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mshitrit
Copy link
Member

/test 4.16-openshift-e2e

@mshitrit
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 24, 2024
@razo7 razo7 marked this pull request as ready for review September 24, 2024 07:55
@openshift-ci openshift-ci bot requested review from beekhof and mshitrit September 24, 2024 07:55
@razo7
Copy link
Member Author

razo7 commented Sep 24, 2024

/retest

1 similar comment
@razo7
Copy link
Member Author

razo7 commented Sep 25, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 7492a80 into medik8s:main Sep 25, 2024
26 checks passed
@razo7
Copy link
Member Author

razo7 commented Nov 6, 2024

/cherry-pick release-0.3

@openshift-cherrypick-robot

@razo7: new pull request created: #146

In response to this:

/cherry-pick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants