Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.4] Set Golang version for specifing the correct toolchain #149

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[release-0.4] Set Golang version for specifing the correct toolchain #149

merged 1 commit into from
Dec 11, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #148

/assign razo7

@razo7
Set Golang version for specifing the correct toolchain
8cac1b0 
Using this specific toolchain we set the minimum requirement for Golang version. 'go command uses its own bundled toolchain when that toolchain is at least as new as the go or toolchain lines in the main module'. https://go.dev/doc/toolchain
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 10, 2024
Merged
@openshift-ci openshift-ci bot requested review from mshitrit and slintes December 10, 2024 21:44
@razo7
Copy link
Member

razo7 commented Dec 10, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Dec 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7
Copy link
Member

razo7 commented Dec 11, 2024

There is an error with Codacy but I am unable to read the output...

@razo7
Copy link
Member

razo7 commented Dec 11, 2024

/override codacy

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@razo7: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • codacy

Only the following failed contexts/checkruns were expected:

  • Codacy Static Code Analysis
  • ci/prow/4.14-ci-bundle-machine-deletion-remediation-bundle
  • ci/prow/4.14-images
  • ci/prow/4.14-openshift-e2e
  • ci/prow/4.14-test
  • ci/prow/4.15-ci-bundle-machine-deletion-remediation-bundle
  • ci/prow/4.15-images
  • ci/prow/4.15-openshift-e2e
  • ci/prow/4.15-test
  • ci/prow/4.16-ci-bundle-machine-deletion-remediation-bundle
  • ci/prow/4.16-images
  • ci/prow/4.16-openshift-e2e
  • ci/prow/4.16-test
  • ci/prow/4.17-ci-bundle-machine-deletion-remediation-bundle
  • ci/prow/4.17-images
  • ci/prow/4.17-openshift-e2e
  • ci/prow/4.17-test
  • ci/prow/4.18-ci-bundle-machine-deletion-remediation-bundle
  • ci/prow/4.18-images
  • ci/prow/4.18-openshift-e2e
  • ci/prow/4.18-test
  • pull-ci-medik8s-machine-deletion-remediation-main-4.14-ci-bundle-machine-deletion-remediation-bundle
  • pull-ci-medik8s-machine-deletion-remediation-main-4.14-images
  • pull-ci-medik8s-machine-deletion-remediation-main-4.14-openshift-e2e
  • pull-ci-medik8s-machine-deletion-remediation-main-4.14-test
  • pull-ci-medik8s-machine-deletion-remediation-main-4.15-ci-bundle-machine-deletion-remediation-bundle
  • pull-ci-medik8s-machine-deletion-remediation-main-4.15-images
  • pull-ci-medik8s-machine-deletion-remediation-main-4.15-openshift-e2e
  • pull-ci-medik8s-machine-deletion-remediation-main-4.15-test
  • pull-ci-medik8s-machine-deletion-remediation-main-4.16-ci-bundle-machine-deletion-remediation-bundle
  • pull-ci-medik8s-machine-deletion-remediation-main-4.16-images
  • pull-ci-medik8s-machine-deletion-remediation-main-4.16-openshift-e2e
  • pull-ci-medik8s-machine-deletion-remediation-main-4.16-test
  • pull-ci-medik8s-machine-deletion-remediation-main-4.17-ci-bundle-machine-deletion-remediation-bundle
  • pull-ci-medik8s-machine-deletion-remediation-main-4.17-images
  • pull-ci-medik8s-machine-deletion-remediation-main-4.17-openshift-e2e
  • pull-ci-medik8s-machine-deletion-remediation-main-4.17-test
  • pull-ci-medik8s-machine-deletion-remediation-main-4.18-ci-bundle-machine-deletion-remediation-bundle
  • pull-ci-medik8s-machine-deletion-remediation-main-4.18-images
  • pull-ci-medik8s-machine-deletion-remediation-main-4.18-openshift-e2e
  • pull-ci-medik8s-machine-deletion-remediation-main-4.18-test
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override codacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@razo7
Copy link
Member

razo7 commented Dec 11, 2024

/override Codacy Static Code Analysis

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@razo7: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Analysis
  • Codacy
  • Code
  • Static

Only the following failed contexts/checkruns were expected:

  • Codacy Static Code Analysis
  • ci/prow/4.14-ci-bundle-machine-deletion-remediation-bundle
  • ci/prow/4.14-images
  • ci/prow/4.14-openshift-e2e
  • ci/prow/4.14-test
  • ci/prow/4.15-ci-bundle-machine-deletion-remediation-bundle
  • ci/prow/4.15-images
  • ci/prow/4.15-openshift-e2e
  • ci/prow/4.15-test
  • ci/prow/4.16-ci-bundle-machine-deletion-remediation-bundle
  • ci/prow/4.16-images
  • ci/prow/4.16-openshift-e2e
  • ci/prow/4.16-test
  • ci/prow/4.17-ci-bundle-machine-deletion-remediation-bundle
  • ci/prow/4.17-images
  • ci/prow/4.17-openshift-e2e
  • ci/prow/4.17-test
  • ci/prow/4.18-ci-bundle-machine-deletion-remediation-bundle
  • ci/prow/4.18-images
  • ci/prow/4.18-openshift-e2e
  • ci/prow/4.18-test
  • pull-ci-medik8s-machine-deletion-remediation-main-4.14-ci-bundle-machine-deletion-remediation-bundle
  • pull-ci-medik8s-machine-deletion-remediation-main-4.14-images
  • pull-ci-medik8s-machine-deletion-remediation-main-4.14-openshift-e2e
  • pull-ci-medik8s-machine-deletion-remediation-main-4.14-test
  • pull-ci-medik8s-machine-deletion-remediation-main-4.15-ci-bundle-machine-deletion-remediation-bundle
  • pull-ci-medik8s-machine-deletion-remediation-main-4.15-images
  • pull-ci-medik8s-machine-deletion-remediation-main-4.15-openshift-e2e
  • pull-ci-medik8s-machine-deletion-remediation-main-4.15-test
  • pull-ci-medik8s-machine-deletion-remediation-main-4.16-ci-bundle-machine-deletion-remediation-bundle
  • pull-ci-medik8s-machine-deletion-remediation-main-4.16-images
  • pull-ci-medik8s-machine-deletion-remediation-main-4.16-openshift-e2e
  • pull-ci-medik8s-machine-deletion-remediation-main-4.16-test
  • pull-ci-medik8s-machine-deletion-remediation-main-4.17-ci-bundle-machine-deletion-remediation-bundle
  • pull-ci-medik8s-machine-deletion-remediation-main-4.17-images
  • pull-ci-medik8s-machine-deletion-remediation-main-4.17-openshift-e2e
  • pull-ci-medik8s-machine-deletion-remediation-main-4.17-test
  • pull-ci-medik8s-machine-deletion-remediation-main-4.18-ci-bundle-machine-deletion-remediation-bundle
  • pull-ci-medik8s-machine-deletion-remediation-main-4.18-images
  • pull-ci-medik8s-machine-deletion-remediation-main-4.18-openshift-e2e
  • pull-ci-medik8s-machine-deletion-remediation-main-4.18-test
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override Codacy Static Code Analysis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@slintes
Copy link
Member

slintes commented Dec 11, 2024

/skip

@slintes
Copy link
Member

slintes commented Dec 11, 2024

/override "Codacy Static Code Analysis"

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@slintes: Overrode contexts on behalf of slintes: Codacy Static Code Analysis

In response to this:

/override "Codacy Static Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 1bdbcc0 into medik8s:release-0.4 Dec 11, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshitrit mshitrit Awaiting requested review from mshitrit

@slintes slintes Awaiting requested review from slintes

Assignees

@razo7 razo7

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @razo7 @slintes