Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Golang version for specifing the correct toolchain #148

Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Dec 10, 2024

Why we need this PR

Using this specific toolchain we set the minimum requirement for Golang version.
"go command uses its own bundled toolchain when that toolchain is at least as new as the go or toolchain lines in the main module" - https://go.dev/doc/toolchain

Changes made

  1. go.mod has a zero (0) patch version. 1.23 -> 1.23.0
  2. Dockerfile was modified to fetch Golang version from go.mod which has major and minor versions. Similarly to how it behaved before

Which issue(s) this PR fixes

Test plan

Using this specific toolchain we set the minimum requirement for Golang version. 'go command uses its own bundled toolchain when that toolchain is at least as new as the go or toolchain lines in the main module'. https://go.dev/doc/toolchain
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@slintes
Copy link
Member

slintes commented Dec 10, 2024

/lgtm

Copy link
Contributor

@clobrano clobrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 marked this pull request as ready for review December 10, 2024 12:41
@openshift-ci openshift-ci bot requested review from beekhof and slintes December 10, 2024 12:41
@razo7
Copy link
Member Author

razo7 commented Dec 10, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit d7e5182 into medik8s:main Dec 10, 2024
23 checks passed
@razo7
Copy link
Member Author

razo7 commented Dec 10, 2024

/cherry-pick release-0.4

@openshift-cherrypick-robot

@razo7: new pull request created: #149

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants