-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-55324: Apply learnings from Mattermost config review #706
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -561,6 +561,10 @@ func (t *Terraform) updateAppConfig(siteURL string, sshc *ssh.Client, jobServerE | |
// Setting to * is more of a quick fix. A proper fix would be to get the DNS name of the first | ||
// node or the proxy and set that. | ||
cfg.ServiceSettings.AllowCorsFrom = model.NewString("*") | ||
cfg.ServiceSettings.EnableOpenTracing = model.NewBool(false) // Large overhead, better to disable | ||
cfg.ServiceSettings.EnableTutorial = model.NewBool(false) // Makes manual testing easier | ||
cfg.ServiceSettings.EnableOnboardingFlow = model.NewBool(false) // Makes manual testing easier | ||
|
||
cfg.EmailSettings.SMTPServer = model.NewString(t.output.MetricsServer.PrivateIP) | ||
cfg.EmailSettings.SMTPPort = model.NewString("2500") | ||
|
||
|
@@ -599,8 +603,10 @@ func (t *Terraform) updateAppConfig(siteURL string, sshc *ssh.Client, jobServerE | |
cfg.SqlSettings.DataSourceReplicas = readerDSN | ||
cfg.SqlSettings.MaxIdleConns = model.NewInt(100) | ||
cfg.SqlSettings.MaxOpenConns = model.NewInt(100) | ||
cfg.SqlSettings.Trace = model.NewBool(false) // Can be enabled for specific tests, but defaulting to false to declutter logs | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's anyways set to false by default. I guess we are being explicit here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I like it to beg explicit in case a user wants to change it at some point. |
||
|
||
cfg.TeamSettings.MaxUsersPerTeam = model.NewInt(50000) | ||
cfg.TeamSettings.MaxUsersPerTeam = model.NewInt(200000) // We don't want to be capped by this limit | ||
cfg.TeamSettings.MaxChannelsPerTeam = model.NewInt64(200000) // We don't want to be capped by this limit | ||
cfg.TeamSettings.EnableOpenServer = model.NewBool(true) | ||
cfg.TeamSettings.MaxNotificationsPerChannel = model.NewInt64(1000) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also set to false by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was more a safety measure, in case it is enabled by default at some point, but we can remove it if you have a strong opinion.