MM-55324: Apply learnings from Mattermost config review #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These configuration changes are the result of a review of the Mattermost config generated by a load-test. Read the full report here: https://mattermost.atlassian.net/wiki/spaces/XYZ/pages/2675015717/Load-test+server+configuration+review
agnivade
reviewed
Mar 14, 2024
| @@ -599,8 +603,10 @@ func (t *Terraform) updateAppConfig(siteURL string, sshc *ssh.Client, jobServerE | |||
| cfg.SqlSettings.DataSourceReplicas = readerDSN | |||
| cfg.SqlSettings.MaxIdleConns = model.NewInt(100) | |||
| cfg.SqlSettings.MaxOpenConns = model.NewInt(100) | |||
| cfg.SqlSettings.Trace = model.NewBool(false) // Can be enabled for specific tests, but defaulting to false to declutter logs | |||
There was a problem hiding this comment.
It's anyways set to false by default. I guess we are being explicit here?
There was a problem hiding this comment.
Yes, I like it to beg explicit in case a user wants to change it at some point.
| @@ -561,6 +561,10 @@ func (t *Terraform) updateAppConfig(siteURL string, sshc *ssh.Client, jobServerE | |||
| // Setting to * is more of a quick fix. A proper fix would be to get the DNS name of the first | |||
| // node or the proxy and set that. | |||
| cfg.ServiceSettings.AllowCorsFrom = model.NewString("*") | |||
| cfg.ServiceSettings.EnableOpenTracing = model.NewBool(false) // Large overhead, better to disable | |||
There was a problem hiding this comment.
This is also set to false by default.
There was a problem hiding this comment.
This was more a safety measure, in case it is enabled by default at some point, but we can remove it if you have a strong opinion.
agnivade
approved these changes
Mar 19, 2024
agarciamontoro
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These configuration changes are the result of a review of the Mattermost config generated by a load-test. Report: https://mattermost.atlassian.net/wiki/spaces/XYZ/pages/2675015717/Load-test+server+configuration+review
Ticket Link
https://mattermost.atlassian.net/browse/MM-55324