Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v1.15.0-rc1 #705

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Bump version to v1.15.0-rc1 #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/deployer.sample.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"AdminEmail": "[email protected]",
"AdminUsername": "sysadmin",
"AdminPassword": "Sys@dmin-sample1",
"LoadTestDownloadURL": "https://github.com/mattermost/mattermost-load-test-ng/releases/download/v1.9.1/mattermost-load-test-ng-v1.9.1-linux-amd64.tar.gz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this out of date somehow? Noticing the bump from v1.9 to v1.15.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is something we need to fix process-wise. We only bump the version in the release branches, but never on master. We may want to merge into master and then cut the branch? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be my expectation to be honest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just have a latest-release URL that always points to the latest tar.gz file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be my expectation to be honest.

Let's test this now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could also work, at which point the pinning would make sense in the release branch only.

"LoadTestDownloadURL": "https://github.com/mattermost/mattermost-load-test-ng/releases/download/v1.15.0-rc1/mattermost-load-test-ng-v1.15.0-rc1-linux-amd64.tar.gz",
"LogSettings": {
"EnableConsole": true,
"ConsoleLevel": "INFO",
Expand Down
2 changes: 1 addition & 1 deletion deployment/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ type Config struct {
// URL from where to download load-test-ng binaries and configuration files.
// The configuration files provided in the package will be overridden in
// the deployment process.
LoadTestDownloadURL string `default:"https://github.com/mattermost/mattermost-load-test-ng/releases/download/v1.9.1/mattermost-load-test-ng-v1.9.1-linux-amd64.tar.gz" validate:"url"`
LoadTestDownloadURL string `default:"https://github.com/mattermost/mattermost-load-test-ng/releases/download/v1.15.0-rc1/mattermost-load-test-ng-v1.15.0-rc1-linux-amd64.tar.gz" validate:"url"`
ElasticSearchSettings ElasticSearchSettings
JobServerSettings JobServerSettings
LogSettings logger.Settings
Expand Down
2 changes: 1 addition & 1 deletion deployment/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ func TestConfigIsValid(t *testing.T) {
baseConfig := func() Config {
return Config{
MattermostDownloadURL: "https://latest.mattermost.com/mattermost-enterprise-linux",
LoadTestDownloadURL: "https://github.com/mattermost/mattermost-load-test-ng/releases/download/v1.9.1/mattermost-load-test-ng-v1.9.1-linux-amd64.tar.gz",
LoadTestDownloadURL: "https://github.com/mattermost/mattermost-load-test-ng/releases/download/v1.15.0-rc1/mattermost-load-test-ng-v1.15.0-rc1-linux-amd64.tar.gz",
}
}

Expand Down
Loading