Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v1.15.0-rc1 #705

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Bump version to v1.15.0-rc1 #705

merged 1 commit into from
Mar 11, 2024

Conversation

agarciamontoro
Copy link
Member

Summary

Preparing release v1.15.0-RC1

Ticket Link

--

@agarciamontoro agarciamontoro added the 2: Dev Review Requires review by a core committer label Mar 11, 2024
@agarciamontoro agarciamontoro changed the base branch from master to release-1.15 March 11, 2024 17:13
@@ -60,7 +60,7 @@
"AdminEmail": "[email protected]",
"AdminUsername": "sysadmin",
"AdminPassword": "Sys@dmin-sample1",
"LoadTestDownloadURL": "https://github.com/mattermost/mattermost-load-test-ng/releases/download/v1.9.1/mattermost-load-test-ng-v1.9.1-linux-amd64.tar.gz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this out of date somehow? Noticing the bump from v1.9 to v1.15.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is something we need to fix process-wise. We only bump the version in the release branches, but never on master. We may want to merge into master and then cut the branch? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be my expectation to be honest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just have a latest-release URL that always points to the latest tar.gz file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be my expectation to be honest.

Let's test this now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could also work, at which point the pinning would make sense in the release branch only.

@agarciamontoro agarciamontoro changed the base branch from release-1.15 to master March 11, 2024 17:16
@agarciamontoro
Copy link
Member Author

Let's modify the process so that we merge this into master and then we cut the branch. Merging into master now.

@streamer45 streamer45 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 11, 2024
@agarciamontoro agarciamontoro merged commit 902ad0d into master Mar 11, 2024
1 check passed
@agarciamontoro agarciamontoro deleted the bump-v1.15.0-rc1 branch March 11, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants