-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to v1.15.0-rc1 #705
Conversation
@@ -60,7 +60,7 @@ | |||
"AdminEmail": "[email protected]", | |||
"AdminUsername": "sysadmin", | |||
"AdminPassword": "Sys@dmin-sample1", | |||
"LoadTestDownloadURL": "https://github.com/mattermost/mattermost-load-test-ng/releases/download/v1.9.1/mattermost-load-test-ng-v1.9.1-linux-amd64.tar.gz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this out of date somehow? Noticing the bump from v1.9 to v1.15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is something we need to fix process-wise. We only bump the version in the release branches, but never on master. We may want to merge into master and then cut the branch? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would be my expectation to be honest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just have a latest-release URL that always points to the latest tar.gz file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would be my expectation to be honest.
Let's test this now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could also work, at which point the pinning would make sense in the release branch only.
Let's modify the process so that we merge this into master and then we cut the branch. Merging into master now. |
Summary
Preparing release v1.15.0-RC1
Ticket Link
--