Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CAP match for some IRC daemons #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix CAP match for some IRC daemons #515

wants to merge 1 commit into from

Commits on Aug 4, 2017

  1. Fix CAP match for some IRC daemons 

    Some IRC daemons such as InspIRCd return an random string after a
client's CAP REQ request.  This would fail to match and block SASL
AUTHENTICATEs.  Also the space after sasl would also block the above
AUTHENTICATEs.

This change:

* allows for emitting that output in logs via debug in config
* stops matching on said field which can be an irrelevant moving
target
* removes the trailing space for the mentioned sasl field

Example:

$ openssl s_client -connect irc.corp.com:6697
...
CAP REQ :sasl
:irc.corp.com CAP 354AAUXBK ACK :sasl
^C
$ openssl s_client -connect irc.corp.com:6697
...
CAP REQ :sasl
:irc.corp.com CAP 354AAUXC8 ACK :sasl
    Nick Silkey committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    87e783d View commit details
    Browse the repository at this point in the history