Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CAP match for some IRC daemons #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

filler
Copy link

@filler filler commented Jun 16, 2017

Some IRC daemons such as InspIRCd return an random string after a
client's CAP REQ request. This would fail to match and block SASL
AUTHENTICATEs. Also the space after sasl would also block the above
AUTHENTICATEs.

This change:

  • allows for emitting that output in logs via debug in config
  • stops matching on said field which can be an irrelevant moving
    target
  • removes the trailing space for the mentioned sasl field

Example InspIRCd output:

$ openssl s_client -connect irc.corp.com:6697
...
CAP REQ :sasl
:irc.corp.com CAP 354AAUXBK ACK :sasl
^C
$ openssl s_client -connect irc.corp.com:6697
...
CAP REQ :sasl
:irc.corp.com CAP 354AAUXC8 ACK :sasl
^C

Some IRC daemons such as InspIRCd return an random string after a
client's CAP REQ request.  This would fail to match and block SASL
AUTHENTICATEs.  Also the space after sasl would also block the above
AUTHENTICATEs.

This change:

* allows for emitting that output in logs via debug in config
* stops matching on said field which can be an irrelevant moving
target
* removes the trailing space for the mentioned sasl field

Example:

$ openssl s_client -connect irc.corp.com:6697
...
CAP REQ :sasl
:irc.corp.com CAP 354AAUXBK ACK :sasl
^C
$ openssl s_client -connect irc.corp.com:6697
...
CAP REQ :sasl
:irc.corp.com CAP 354AAUXC8 ACK :sasl
@Throne3d
Copy link

I'm not really sure that this project is being updated any more – I forked it a while back (irc-upd on npm) and recently fixed up the SASL handling to be more compliant with the IRCv3 spec (including a change similar to this one – it requires only that sasl be one of the arguments in the ACK response, and does not attempt to match the ident – and it now also emits an error if it gets a NAK response to the request). You might consider looking at that version of the library instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants