Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed analysis_inputs script to separate MS options #76

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Changed analysis_inputs script to separate MS options #76

merged 1 commit into from
Dec 13, 2023

Conversation

GuiMacielPereira
Copy link
Collaborator

Description of work:

  • The fix is as simple as moving these attributes from the parent class to the child classes

To test:

  • Run default script and check it doesn't crash after the first MS correction. Can keyboard interrupt script afterwards.

Fixes #73 .

@GuiMacielPereira
Changed analysis_inputs script to separate MS options
5b6b541 
- The fix is as simple as moving these attributes from the parent class to the child classes
@GuiMacielPereira GuiMacielPereira linked an issue Dec 8, 2023 that may be closed by this pull request
Separate Multiple Scattering options for Forward and Backward classes #73
Closed
@MialLewis MialLewis merged commit acb3219 into main Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MialLewis MialLewis MialLewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate Multiple Scattering options for Forward and Backward classes
2 participants
@GuiMacielPereira @MialLewis