Replace Miniconda with Miniforge. Pin MySQL. #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehart
force-pushed
the
GH166_use_Miniforge
branch
from
1f420bb to
1173908
Compare
leehart
force-pushed
the
GH166_use_Miniforge
branch
from
bbc77fc to
abc7a03
Compare
leehart
force-pushed
the
GH166_use_Miniforge
branch
from
4d65d77 to
284a659
Compare
leehart
changed the title
|
@alimanfoo Does this look OK? |
|
@amakunin Does this look OK? |
amakunin
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Hi @leehart - thanks, all looks great and covers all of my queries nicely.
FYI, I spotted that there might be some redundancy, e.g. in installation of libmamba solver - it is already used by default by miniforge (and more recent versions of miniconda). Still, that is not something that needs to be fixed - as the installer works just fine:)
|
Thanks for the review @amakunin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: issue #166 , #165, #152