Update cmake build tools #347
Conversation
|
I'm curious why you call this an "update" since it seems to be adding CMake tooling from scratch. Did this originate somewhere else? I'm happy to consider this, but I'm a little hesitant to add an alternative build system before we clean up the one we have and get automated testing working properly. Also I'd like to hear what the use-case for this is that would make in worth the maintenance overhead above just having a normal LuaRocks based install. Lastly, will you be around to keep iterating on this as we possibly shuffle things around in the build. It would be good if we had somebody that was actually going to maintain the CMake side of things if we're going to include it here. |
There was a problem hiding this comment.
I'm not in a position to test this, so (in addition to answering the questions in my other comment) automated tests will be required before we even consider merging. Consider rebasing or a merge from master after testing related PRs like #356 have landed. We'll want some sort of check to that confirms the CMake system is functional with the matching current source tree.
I believe there are many people who have the same problem as me, which is "cannot compile socket library on windows". Because makefiles are better for development environment on *nix systems |
|
#415 added some Windows CI jobs checking the build on the Windows side of things, at least with MSCV. #315 also has some cmake related stuff with a different route to build. @leso-kn Any input here? I'm not a Windows guy at all. I'm happy to facilitate contributions but I'm kind of out of my depth on the Windows side of things. |
No description provided.