Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded init_clock_res #835

Closed
wants to merge 3 commits into from
Closed

Remove unneeded init_clock_res #835

wants to merge 3 commits into from

Conversation

SeanTAllen
Copy link
Contributor

Closes #816

@SeanTAllen
Copy link
Contributor Author

sgx-lkl-musl review is here:

lsds/sgx-lkl-musl#40

@prp
Copy link
Member

prp commented Sep 24, 2020

Shouldn't this also remove the associated enclave_config parameter?

@SeanTAllen
Copy link
Contributor Author

@wintersteiger Should I remove the enclave_config parameter? I think you said you would do after this was done.

Let me know.

@wintersteiger
Copy link
Contributor

@SeanTAllen sure, go ahead and remove them if you like. There are a couple of places in the launcher and the config parser that should be removed but the compiler might not throw errors. I'm happy to take another look later or after this is merged.

wintersteiger
wintersteiger approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@wintersteiger wintersteiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SeanTAllen
Copy link
Contributor Author

@wintersteiger I removed as much as I thought needed to go and it compiles now. I'm not sure if it will pass tests or not. Can you take a look to see if I missed anything?

@wintersteiger
Copy link
Contributor

This looks perfect to me, you got all the relevant bits I think. The CI build failure is unrelated as far as I can tell, I'll try to schedule a re-run.

@SeanTAllen SeanTAllen mentioned this pull request Sep 25, 2020
Open
2 tasks
vtikoo
vtikoo approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@vtikoo vtikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this mean we no longer intercept SYS_clock_getres?

@SeanTAllen
Copy link
Contributor Author

sgx-lkl-musl portion has been merged. i bumped the submodule here. once it passes CI, I will squash and merge.

@SeanTAllen SeanTAllen closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidchisnall davidchisnall davidchisnall approved these changes

@wintersteiger wintersteiger wintersteiger approved these changes

@vtikoo vtikoo vtikoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dead code in sgx-lkl-musl
5 participants
@SeanTAllen @prp @wintersteiger @davidchisnall @vtikoo