Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead code in sgx-lkl-musl #816

Open
2 tasks
davidchisnall opened this issue Aug 24, 2020 · 3 comments
Open
2 tasks

Dead code in sgx-lkl-musl #816

davidchisnall opened this issue Aug 24, 2020 · 3 comments
Labels
p1 Medium priority

Comments

@davidchisnall
Copy link
Contributor

We have several functions that were work-arounds for missing features that are now fixed. These have complicated some of the code cleanup, as seen in #815, where we're adding code to support these hacks. We should remove them and simplify the associated code:

  • init_sysconf should be obsolete now that we're intercepting the sysconf system call.
  • init_clock_res should be obsolete now that LKL is managing the clocks.

@SeanTAllen, you've touched some code related to both of these, I think. Can you take a look once #815 has landed?

@github-actions github-actions bot added the needs-triage Bug does not yet have a priority assigned label Aug 24, 2020
@SeanTAllen SeanTAllen self-assigned this Aug 24, 2020
@bodzhang bodzhang added this to Needs triage in Issue triage via automation Aug 28, 2020
@bodzhang bodzhang moved this from Needs triage to Proposed p1 in Issue triage Aug 28, 2020
@bodzhang bodzhang added p1 Medium priority and removed needs-triage Bug does not yet have a priority assigned labels Sep 4, 2020
@bodzhang bodzhang removed this from Proposed p1 in Issue triage Sep 4, 2020
@wintersteiger
Copy link
Contributor

See also #576

@SeanTAllen
Copy link
Contributor

init_sysconf isn't dead code. only doing init_clock_res

@SeanTAllen
Copy link
Contributor

PR opened #835

@SeanTAllen SeanTAllen removed their assignment Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants