New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dead code in sgx-lkl-musl #816
Labels
p1
Medium priority
Comments
github-actions
bot
added
the
needs-triage
Bug does not yet have a priority assigned
label
Aug 24, 2020
Closed
bodzhang
added
p1
Medium priority
and removed
needs-triage
Bug does not yet have a priority assigned
labels
Sep 4, 2020
See also #576 |
init_sysconf isn't dead code. only doing init_clock_res |
PR opened #835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have several functions that were work-arounds for missing features that are now fixed. These have complicated some of the code cleanup, as seen in #815, where we're adding code to support these hacks. We should remove them and simplify the associated code:
init_sysconf
should be obsolete now that we're intercepting the sysconf system call.init_clock_res
should be obsolete now that LKL is managing the clocks.@SeanTAllen, you've touched some code related to both of these, I think. Can you take a look once #815 has landed?
The text was updated successfully, but these errors were encountered: