Development: Remove unused localVCenabled value from client
#10478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
server
helios-aet
bot
temporarily deployed
to
artemis-test4.artemis.cit.tum.de
helios-aet
bot
temporarily deployed
to
artemis-test5.artemis.cit.tum.de
WalkthroughThis pull request removes the Changes
Possibly related PRs
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
tobias-lippert
requested changes
Mar 25, 2025
src/test/javascript/spec/component/account/user-settings-container.component.spec.ts
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from Work In Progress
to Ready For Review
in Artemis Development
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/test/javascript/spec/component/account/user-settings-container.component.spec.ts (1)
42-48: Align spy verifications with coding guidelinesThe test looks good overall, but there are a couple of improvements that would better align with the coding guidelines:
- For spy verification on line 45, use the more specific
toHaveBeenCalledOnce()instead of the generictoHaveBeenCalled()- For boolean expectation on line 47, use
toBeFalse()instead oftoEqual(false)as per the guidelinesit('should initialize with loaded user', () => { const getAuthenticationSpy = jest.spyOn(accountService, 'getAuthenticationState'); fixture.detectChanges(); - expect(getAuthenticationSpy).toHaveBeenCalled(); + expect(getAuthenticationSpy).toHaveBeenCalledOnce(); expect(comp.currentUser?.id).toEqual(99); - expect(comp.isAtLeastTutor).toEqual(false); + expect(comp.isAtLeastTutor).toBeFalse(); });
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/test/javascript/spec/component/account/user-settings-container.component.spec.ts(1 hunks)src/test/javascript/spec/component/exercises/shared/exercise-scores/exercise-scores.component.spec.ts(0 hunks)
💤 Files with no reviewable changes (1)
- src/test/javascript/spec/component/exercises/shared/exercise-scores/exercise-scores.component.spec.ts
🧰 Additional context used
📓 Path-based instructions (1)
`src/test/javascript/spec/**/*.ts`: jest: true; mock: NgMocks; bad_practices: avoid_full_module_import; perf_improvements: mock_irrelevant_deps; service_testing: mock_http_for_logi...
src/test/javascript/spec/**/*.ts: jest: true; mock: NgMocks; bad_practices: avoid_full_module_import; perf_improvements: mock_irrelevant_deps; service_testing: mock_http_for_logic; no_schema: avoid_NO_ERRORS_SCHEMA; expectation_specificity: true; solutions: {boolean: toBeTrue/False, reference: toBe, existence: toBeNull/NotNull, undefined: toBeUndefined, class_obj: toContainEntries/toEqual, spy_calls: {not_called: not.toHaveBeenCalled, once: toHaveBeenCalledOnce, with_value: toHaveBeenCalledWith|toHaveBeenCalledExactlyOnceWith}}
src/test/javascript/spec/component/account/user-settings-container.component.spec.ts
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Build and Push Docker Image / Build Docker Image for ls1intum/artemis
- GitHub Check: Build and Push Docker Image / Build Docker Image for ls1intum/artemis
- GitHub Check: Build .war artifact
- GitHub Check: client-tests-selected
- GitHub Check: client-tests
- GitHub Check: server-tests
- GitHub Check: Analyse
🔇 Additional comments (2)
src/test/javascript/spec/component/account/user-settings-container.component.spec.ts (2)
31-31: LGTM - Using MockAccountService as requestedThe changes properly implement the previous review comment by using MockAccountService instead of a manual mock.
25-25: Simplification of imports looks goodThe component imports have been simplified to only include what's necessary, which improves maintainability.
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
SimonEntholzer
force-pushed
the
chore/remove-gitlab-remove-localVC-enabled-from-client
branch
from
528b6fc to
5dfa308
Compare
github-actions
bot
added
the
assessment
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
|
The repeated necessary effort of resolving the merge conflicts introduced by the client code refactorings leads me to close this PR |
krusche
deleted the
chore/remove-gitlab-remove-localVC-enabled-from-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
In the client are still remnants of the gitlab setup.
As the localVCenabled flag is always true now, the client code depending on it can be removed.
Description
Steps for Testing
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Test Coverage
Screenshots
no UI change
Summary by CodeRabbit