Skip to content

Commit 528b6fc

Browse files
fix test and merge conflict
1 parent 5db8db8 commit 528b6fc

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed
Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { ComponentFixture, TestBed } from '@angular/core/testing';
2-
import { of } from 'rxjs';
32
import { ActivatedRoute, Router } from '@angular/router';
43
import { MockNgbModalService } from '../../helpers/mocks/service/mock-ngb-modal.service';
54
import { MockTranslateService } from '../../helpers/mocks/service/mock-translate.service';
@@ -9,45 +8,42 @@ import { UserSettingsContainerComponent } from 'app/shared/user-settings/user-se
98
import { MockRouter } from '../../helpers/mocks/mock-router';
109
import { AccountService } from 'app/core/auth/account.service';
1110
import { MockActivatedRoute } from '../../helpers/mocks/activated-route/mock-activated-route';
11+
import { MockAccountService } from '../../helpers/mocks/service/mock-account.service';
1212

1313
describe('UserSettingsContainerComponent', () => {
1414
let fixture: ComponentFixture<UserSettingsContainerComponent>;
1515
let comp: UserSettingsContainerComponent;
1616

17-
let accountServiceMock: { getAuthenticationState: jest.Mock; isAtLeastTutor: jest.Mock };
18-
1917
let translateService: TranslateService;
18+
let accountService: AccountService;
2019

2120
const router = new MockRouter();
2221
router.setUrl('');
2322

2423
beforeEach(async () => {
25-
accountServiceMock = {
26-
getAuthenticationState: jest.fn(() => of({ id: 13 } as any)),
27-
isAtLeastTutor: jest.fn(() => true),
28-
};
29-
3024
await TestBed.configureTestingModule({
3125
imports: [UserSettingsContainerComponent],
3226
providers: [
3327
{ provide: TranslateService, useClass: MockTranslateService },
3428
{ provide: NgbModal, useClass: MockNgbModalService },
3529
{ provide: Router, useValue: router },
3630
{ provide: ActivatedRoute, useValue: new MockActivatedRoute() },
37-
{ provide: AccountService, useValue: accountServiceMock },
31+
{ provide: AccountService, useClass: MockAccountService },
3832
],
3933
}).compileComponents();
4034

4135
fixture = TestBed.createComponent(UserSettingsContainerComponent);
4236
comp = fixture.componentInstance;
4337
translateService = TestBed.inject(TranslateService);
38+
accountService = TestBed.inject(AccountService);
4439
translateService.currentLang = 'en';
4540
});
4641

4742
it('should initialize with loaded user', () => {
43+
const getAuthenticationSpy = jest.spyOn(accountService, 'getAuthenticationState');
4844
fixture.detectChanges();
49-
expect(accountServiceMock.getAuthenticationState).toHaveBeenCalled();
50-
expect(comp.currentUser?.id).toEqual(13);
51-
expect(comp.isAtLeastTutor).toEqual(true);
45+
expect(getAuthenticationSpy).toHaveBeenCalled();
46+
expect(comp.currentUser?.id).toEqual(99);
47+
expect(comp.isAtLeastTutor).toEqual(false);
5248
});
5349
});

src/test/javascript/spec/component/exercises/shared/exercise-scores/exercise-scores.component.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,12 @@ import { ExerciseScoresComponent, FilterProp } from 'app/exercise/exercise-score
1717
import { ExerciseService } from 'app/exercise/exercise.service';
1818
import { ParticipationService } from 'app/exercise/participation/participation.service';
1919
import { ResultService } from 'app/exercise/result/result.service';
20-
import { ProfileService } from 'app/shared/layouts/profiles/profile.service';
2120
import { Range } from 'app/shared/util/utils';
2221
import dayjs from 'dayjs/esm';
2322
import { Subscription, of } from 'rxjs';
2423
import { MockCourseManagementService } from '../../../../helpers/mocks/service/mock-course-management.service';
2524
import { MockExerciseService } from '../../../../helpers/mocks/service/mock-exercise.service';
2625
import { MockParticipationService } from '../../../../helpers/mocks/service/mock-participation.service';
27-
import { MockProfileService } from '../../../../helpers/mocks/service/mock-profile.service';
2826
import { MockProgrammingSubmissionService } from '../../../../helpers/mocks/service/mock-programming-submission.service';
2927
import { MockResultService } from '../../../../helpers/mocks/service/mock-result.service';
3028

0 commit comments

Comments
 (0)