add support for manually setting outcome #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have seen some instances in the past where the usage of this action was causing some issues, if the action was used in sub-workflows (which were triggered with the
workflow_call
trigger).This is because the action really goes through all the jobs in the (complete, in this composite) workflow and checks all the outcome.
This means that this action can:
failure
even though all jobs in the specific workflow where it's defined were successful.Unfortunately, it's not possible to access the
needs
context from within a GitHub action (which would allow filtering the jobs to check for the ones the action depends on).This is why this PR provides a different solution: It allows the user of the action to manually set the outcome (instead of letting the action detect the outcome). At the level of the action definition, the
needs
context can be accessed and can be used in a simple evaluation over all declared dependencies as follows:Which means the issue can be circumvented with a usage of the action like this:
Changes
Testing