fix job outcome reporting on cancelled job #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
force-pushed
the
fix-job-reporting-on-cancellation
branch
from
8bd2509 to
558ac22
Compare
silv-io
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
LGTM!
I think the original reason why we didn't add that was that forcing a re-run would cause the old run to cancel. So merging a PR right after another could show up as a failed workflow run.
However, thinking more about it this might have been a erroneous thought, since cancelling the workflow would then in turn also cancel the tinybird reporting itself.
|
Actually, that's only true if you have only one concurrent run (which usually isn't the case on Anyways, I think this is the right change right now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During the testing of the new
outcomefeature introduced in #21, we realized that the reporting for jobs does not work correctly in case of cancellations (due to timeouts or manual cancellations).This PR addresses this issue.
Changes
Testing