Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP Version Support and Development Dependencies #65

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Jan 11, 2025

This pull request was created by Sweep to resolve the following request by @curtisdelicata:

refactor for php 8.4

Continue chatting at https://sweep-chat-demo.vercel.app/c/11d35330-da78-4b4a-b9d4-96cb4f91da2c.

Purpose

Upgrade the library's PHP version support and modernize development dependencies to ensure compatibility with the latest PHP versions and development tools.

Description

This pull request introduces several key updates to the project's configuration and testing infrastructure:

  • Upgraded minimum PHP version support from 8.3 to 8.4
  • Updated development dependencies to their latest versions
  • Modernized PHPUnit configuration with XML schema support
  • Refactored test file to use newer PHPUnit testing attributes and syntax

Summary

  • Updated composer.json:
    • Changed PHP requirement to >=8.4
    • Updated development dependencies:
      • phpunit/phpunit to ^11.0
      • squizlabs/php_codesniffer to ^3.8
      • rector/rector to ^1.0
      • driftingly/rector-laravel to ^1.0
  • Modified tests/phpunit.xml:
    • Added XML schema support
    • Enabled requireCoverageMetadata
  • Refactored tests/library/Gedcom/ParserTest.php:
    • Used PHPUnit 11 attributes
    • Improved type declarations
    • Simplified test method assertions

@curtisdelicata curtisdelicata merged commit 75c290d into main Jan 11, 2025
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant