Merge pull request #65 from liberu-genealogy/sweep/Update-PHP-Version…

…-Support-and-Development-Dependencies Update PHP Version Support and Development Dependencies
liberu-genealogy · Jan 11, 2025 · 75c290d · 75c290d
2 parents 53cc01b + 4a0d296
commit 75c290d
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 29 deletions.
diff --git a/composer.json b/composer.json
@@ -1,18 +1,18 @@
 {
     "name": "liberu-genealogy/php-gedcom",
-    "description": "A GEDCOM file parser (read + write) for PHP 8.0+",
-    "type": "library",
+    "description": "A GEDCOM file parser (read + write) for PHP 8.4+",
+    "type": "library", 
     "keywords": ["gedcom","parser"],
     "homepage": "http://github.com/familytree365/php-gedcom",
     "license": "MIT",
     "require": {
-        "php": ">=8.3"
+        "php": ">=8.4"
     },
     "require-dev": {
-        "phpunit/phpunit": "11.*",
-        "squizlabs/php_codesniffer": "3.6.*",
-        "rector/rector": "*",
-        "driftingly/rector-laravel": "^0.25.0"
+        "phpunit/phpunit": "^11.0",
+        "squizlabs/php_codesniffer": "^3.8",
+        "rector/rector": "^1.0",
+        "driftingly/rector-laravel": "^1.0"
     },
     "autoload": {
         "psr-4": {

diff --git a/tests/library/Gedcom/ParserTest.php b/tests/library/Gedcom/ParserTest.php
@@ -16,32 +16,28 @@
 namespace GedcomTest;
 
 use Gedcom\Parser;
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
 
 /**
  * Class ParserTest.
  */
-class ParserTest extends \PHPUnit\Framework\TestCase
+class ParserTest extends TestCase
 {
-    /**
-     * @var \Gedcom\Parser
-     */
-    protected $parser = null;
+    private Parser $parser;
+    private ?Gedcom $gedcom = null;
 
-    /**
-     * @var \Gedcom\Gedcom
-     */
-    protected $gedcom = null;
-
-    public function setUp(): void
+    protected function setUp(): void
     {
         $this->parser = new Parser();
         $this->gedcom = $this->parser->parse(\TEST_DIR . '/stresstestfiles/TGC551LF.ged');
     }
 
-    public function testNoErrors()
+    #[Test]
+    public function testNoErrors(): void
     {
-        $ee = $this->parser->getErrors();
-        $this->assertEquals(1, count($ee));
+        $errors = $this->parser->getErrors();
+        $this->assertCount(1, $errors);
     }
 
     public function testRecordCounts()

diff --git a/tests/phpunit.xml b/tests/phpunit.xml
@@ -1,10 +1,16 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit bootstrap="bootstrap.php" colors="true" displayDetailsOnTestsThatTriggerDeprecations="true" displayDetailsOnTestsThatTriggerErrors="true" displayDetailsOnTestsThatTriggerNotices="true" displayDetailsOnTestsThatTriggerWarnings="true">
-	<testsuites>
-		<testsuite name="default">
-			<directory>
-				library/Gedcom/
-			</directory>
-		</testsuite>
-	</testsuites>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.0/phpunit.xsd"
+         bootstrap="bootstrap.php"
+         colors="true"
+         displayDetailsOnTestsThatTriggerDeprecations="true"
+         displayDetailsOnTestsThatTriggerErrors="true" 
+         displayDetailsOnTestsThatTriggerNotices="true"
+         displayDetailsOnTestsThatTriggerWarnings="true"
+         requireCoverageMetadata="true">
+    <testsuites>
+        <testsuite name="default">
+            <directory>library/Gedcom/</directory>
+        </testsuite>
+    </testsuites>
 </phpunit>