Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable building examples using option #287

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Disable building examples using option #287

wants to merge 4 commits into from

Conversation

lindemeier
Copy link

  • fix compiler warnings
  • add option that disables building examples

plusk01
plusk01 reviewed Jan 29, 2023
View reviewed changes
CMakeLists.txt
@@ -6,6 +6,8 @@ set(PACKAGE_NAME matplotlib_cpp)
set(INSTALL_CONFIGDIR ${CMAKE_INSTALL_LIBDIR}/${PACKAGE_NAME}/cmake)


option(BUILD_EXAMPLES "Build examples" OFF)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should prepend options with MATPLOTLIB_CPP_*, .e.g., MATPLOTLIB_CPP_BUILD_EXAMPLES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plusk01 plusk01 plusk01 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lindemeier @plusk01