Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review pass 1 #35

Merged
merged 5 commits into from
Dec 1, 2015
Merged

Code review pass 1 #35

merged 5 commits into from
Dec 1, 2015

Conversation

ehsanmasdar
Copy link
Member

No description provided.

@smo-key
Copy link
Member

smo-key commented Dec 1, 2015

@homu r+

@homu
Copy link
Contributor

homu commented Dec 1, 2015

📌 Commit 7a3999c has been approved by smo-key

homu added a commit that referenced this pull request Dec 1, 2015
@homu
Auto merge of #35 - lasarobotics:codereview-1, r=smo-key
cd82687 
Code review pass 1
@homu
Copy link
Contributor

homu commented Dec 1, 2015

⌛ Testing commit 7a3999c with merge 4b2ed52...

homu added a commit that referenced this pull request Dec 1, 2015
@homu
Auto merge of #35 - lasarobotics:codereview-1, r=smo-key
4b2ed52 
Code review pass 1
@homu
Copy link
Contributor

homu commented Dec 1, 2015

☀️ Test successful - status

@homu homu merged commit 7a3999c into staging Dec 1, 2015
@smo-key smo-key deleted the codereview-1 branch December 1, 2015 03:37
@homu homu mentioned this pull request Dec 1, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsanmasdar @smo-key @homu