Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modern Robotics Gyroscope Support #32

Closed
wants to merge 9 commits into from
Closed

Modern Robotics Gyroscope Support #32

wants to merge 9 commits into from

Conversation

ehsanmasdar
Copy link
Member

No description provided.

@ehsanmasdar
Basic I2C driver to read from Modern Robotics Gyroscope
74792d1
@ehsanmasdar
Fix offset values and tweak readValue to assume unsigned bytes
a4d312c
@ehsanmasdar
Remove nonexistent file
725bd8f
@ehsanmasdar
Rename sample gyroscope OPMode
a7d7426
@ehsanmasdar
Add gyro reset functionality and documentation to driver
ba29569
@ehsanmasdar
Merge branch 'staging' into feature-gyro
e8537b4 
Conflicts:
	ftc-library/src/main/java/com/lasarobotics/library/monkeyc/MonkeyC.java
	ftc-library/src/main/java/com/lasarobotics/library/monkeyc/MonkeyData.java
	ftc-library/src/main/java/com/lasarobotics/library/util/MathUtil.java
	sample/src/main/java/com/qualcomm/ftcrobotcontroller/opmodes/FtcOpModeRegister.java
@ehsanmasdar
Remove extra command in build.gradle
bbb0df4
@ehsanmasdar
Copy link
Member Author

@smo-key Please test and sign off :)

@smo-key
Copy link
Member

smo-key commented Oct 23, 2015

@Oksisane Code looks good - let's test tomorrow at lunch.

@ethan-schaffer
Copy link
Contributor

@smo-key @oksisane you two are welcome to test on the 4290 bot.

On Thu, Oct 22, 2015 at 8:43 PM, Arthur Pachachura <[email protected]

wrote:

@Oksisane https://github.com/Oksisane Code looks good - let's test
tomorrow at lunch.

—
Reply to this email directly or view it on GitHub
#32 (comment)
.

@smo-key
Copy link
Member

smo-key commented Oct 23, 2015

Thank you, @ethan-schaffer!

@ethan-schaffer
Copy link
Contributor

No problem @smo-key!

On Thu, Oct 22, 2015 at 9:04 PM, Arthur Pachachura <[email protected]

wrote:

Thank you, @ethan-schaffer https://github.com/ethan-schaffer!

—
Reply to this email directly or view it on GitHub
#32 (comment)
.

@smo-key
Copy link
Member

smo-key commented Oct 23, 2015

@Oksisane Tested. Please make a few changes:

  • All methods should return a signed integer. signed = (unsigned >= 65526/2) ? 65525 - unsigned : unsigned; should work, maybe some binary logic would be better
  • Fix the stall when calling resetHeading() from init()

Also, the gyro is inaccurate when it moves really fast. Can you limit this somehow?

@smo-key
Copy link
Member

smo-key commented Oct 23, 2015

@homu r-

@homu
Copy link
Contributor

homu commented Dec 1, 2015

☔ The latest upstream changes (presumably #35) made this pull request unmergeable. Please resolve the merge conflicts.

@smo-key smo-key changed the title Feature gyro Modern Robotics Gyroscope Support Dec 1, 2015
@smo-key smo-key closed this Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehsanmasdar @smo-key @ethan-schaffer @homu