-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better exception handling for remote code sandbox #160
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1106707
Introudce new exceptions for remote sandbox errors
humpydonkey aca7b8e
Bug fix: avoid double close the sandbox; Catch exception in E2B close()
humpydonkey 7a69661
Better handle failure when checking sandbox liveness
humpydonkey 0f3867d
Add ntoebook.close
humpydonkey 6d8e2cb
Add missing file
humpydonkey 8dff443
Bump e2b version; Add timeout to _check_sandbox_liveness
humpydonkey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
"""Vision Agent exceptions.""" | ||
|
||
|
||
class InvalidApiKeyError(Exception): | ||
"""Exception raised when the an invalid API key is provided. This error could be raised from any SDK code, not limited to a HTTP client.""" | ||
|
||
def __init__(self, message: str): | ||
self.message = f"""{message} | ||
For more information, see https://landing-ai.github.io/landingai-python/landingai.html#manage-api-credentials""" | ||
super().__init__(self.message) | ||
|
||
def __str__(self) -> str: | ||
return self.message | ||
|
||
|
||
class RemoteSandboxError(Exception): | ||
"""Exception related to remote sandbox.""" | ||
|
||
is_retryable = False | ||
|
||
|
||
class RemoteSandboxCreationError(RemoteSandboxError): | ||
"""Exception raised when failed to create a remote sandbox. | ||
This could be due to the remote sandbox service is unavailable. | ||
""" | ||
|
||
is_retryable = False | ||
|
||
|
||
class RemoteSandboxExecutionError(RemoteSandboxError): | ||
"""Exception raised when failed in a remote sandbox code execution.""" | ||
|
||
is_retryable = False | ||
|
||
|
||
class RemoteSandboxClosedError(RemoteSandboxError): | ||
"""Exception raised when a remote sandbox is dead. | ||
This is retryable in the sense that the user can try again with a new sandbox. Can't be retried in the same sandbox. | ||
When this error is raised, the user should retry by create a new VisionAgent (i.e. a new sandbox). | ||
""" | ||
|
||
is_retryable = True | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, @yzld2002, new exception classes