Better exception handling for remote code sandbox #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humpydonkey
commented
Jul 2, 2024
Comment on lines
+22
to
+42
| class RemoteSandboxCreationError(RemoteSandboxError): | ||
| """Exception raised when failed to create a remote sandbox. | ||
| This could be due to the remote sandbox service is unavailable. | ||
| """ | ||
|
|
||
| is_retryable = False | ||
|
|
||
|
|
||
| class RemoteSandboxExecutionError(RemoteSandboxError): | ||
| """Exception raised when failed in a remote sandbox code execution.""" | ||
|
|
||
| is_retryable = False | ||
|
|
||
|
|
||
| class RemoteSandboxClosedError(RemoteSandboxError): | ||
| """Exception raised when a remote sandbox is dead. | ||
| This is retryable in the sense that the user can try again with a new sandbox. Can't be retried in the same sandbox. | ||
| When this error is raised, the user should retry by create a new VisionAgent (i.e. a new sandbox). | ||
| """ | ||
|
|
||
| is_retryable = True |
There was a problem hiding this comment.
fyi, @yzld2002, new exception classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of changes to improve remote sandbox error handling.
Changes
RemoteSandboxErrorexception classes so the client can catch and handle them differently.self.interpreter.kill()twice.