Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements and fixes for code generation #114

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Minor improvements and fixes for code generation #114

merged 6 commits into from
Jun 5, 2024

Conversation

humpydonkey
Copy link
Collaborator

@humpydonkey humpydonkey commented Jun 5, 2024 •
edited
Loading

Changes

  1. Add a new save_video() tool for a more stable video serialization behavior.
  2. Save image as an intermediate output when save_image() tool is called.
  3. Add default imports:typing.* to avoid typing not found error.
  4. Keep the e2b sandbox alive for 5min when it runs a command.

@humpydonkey
1. Add save_video tool for better video serialization
417c81d 
2. Save image as an intermediate output when save_image is called
3. Add default imports from typing.*
@humpydonkey
Fix lint; Add keep alive
a069995
@humpydonkey
Add fps as a param in save_video()
dbdc846
dillonalaird
dillonalaird approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AsiaCao AsiaCao merged commit cff0756 into main Jun 5, 2024
7 checks passed
@AsiaCao AsiaCao deleted the minor-improvements-6-05 branch June 5, 2024 20:03
@humpydonkey humpydonkey mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillonalaird dillonalaird dillonalaird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humpydonkey @dillonalaird @AsiaCao