Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing typing module error and improve load_image() #116

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Fix missing typing module error and improve load_image() #116

merged 7 commits into from
Jun 5, 2024

Conversation

humpydonkey
Copy link
Collaborator

@humpydonkey humpydonkey commented Jun 5, 2024 •
edited by AsiaCao
Loading

Changes

  1. My previous PR (Minor improvements and fixes for code generation #114) doesn't fix the import typing.* error properly. This PR fixes it and improve the way we append default imports, make it easier to maintain.
  2. Tweak docs to avoid code failure around load_image()
  3. Minor fix for lint errors

dillonalaird
dillonalaird approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AsiaCao AsiaCao merged commit daa4831 into main Jun 5, 2024
7 checks passed
@AsiaCao AsiaCao deleted the minor-improvements-6-051 branch June 5, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillonalaird dillonalaird dillonalaird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humpydonkey @dillonalaird @AsiaCao