feat(BA-533): Add delete path API to storage watcher #3548
+71
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:storage-proxy
This was referenced Jan 24, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
fregataa
changed the title
Comment on lines
+687
to
+691
| elif p.is_file(): | ||
| if self.watcher is not None: | ||
| await self.watcher.request_task(DeletePathTask(p)) | ||
| else: | ||
| await aiofiles.os.remove(p) |
There was a problem hiding this comment.
I believe there might be a better way to decide whether the watcher should monitor, rather than using if statements for branching.
At the very least, is there a way to wrap the file removal and write operations at the time of creation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3483 (BA-533)
Checklist: (if applicable)